Increased Json MaxDepth to 128 #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently the unit tests are failing due to an old URL in a test, and is not related to this change. I made a new PR to fix this in #1651. |
lahma
approved these changes
Nov 28, 2023
|
Perfect. Perhaps it can then be released with the upcoming v11. |
|
@lahma Any chance of merging this? I'm still having the issue of not being able to generate clients with NSwag, and it would be nice to have it included in a future release to resolve this. |
|
We are waiting for Rico as he does the final call... |
|
I think this is fine... we should not expose Newtonsoft.Json serializer internals as eventually NJS and NSwag will switch to STJ for schema serialization and this option would then go away anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using NSwag on schemas with large depths causes an exception to be thrown due to the MaxDepth default setting of 64. I am not aware of any way of customizing the Json settings for parsing the schema in a project when using NSwag, as it invokes the precompiled DLL directly. More context here: RicoSuter/NSwag#4394. #1565 is also related, but can be solved by modifying the settings in the project.
I'm not sure if it is the best approach to just change the default setting in this project to solve it. There doesn't seem to be a way of passing in a
JsonSerializerSettingsobject or func to modify it inFromJsonAsync(called from here in NSwag). If there was such an option, the default wouldn't have to be modified here but it could be changed in NSwag where the issue is relevant.